[Kde-games-devel] Review Request 109880: New shuffling algorithm

[Albert Astals Cid]

> On April 10, 2013, 8:42 p.m., Albert Astals Cid wrote:
> > The code's much easier to understand now. Thanks a lot :-)
> > 
> > So now that we can understand the code, can you explain what's the improvement this provides over the current code?
> 
> Ashwin Rajeev wrote:
>     In previous case everything was left to random, so the minimum moves to win is unpredictable. In easy level i once won with 11 moves that means in that board more than 14 cells remained unmoved. I also got 34 moves in easy level. This make getting highscore on the basis of luck. Since there is custom level with 9 cells leaving everything on random is not a good idea.

Ok, this makes sense. I'm going to give you a ship it even if i don't consider myself the sole owner of the knetwalk code, the kdegames community is, so I'd wait one or two days before commiting in case anyone else has a last minute comment.

Good work :-)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109880/#review30871
-----------------------------------------------------------


On April 10, 2013, 4:08 p.m., Ashwin Rajeev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109880/
> -----------------------------------------------------------
> 
> (Updated April 10, 2013, 4:08 p.m.)
> 
> 
> Review request for KDE Games, Albert Astals Cid and Parker Coates.
> 
> 
> Description
> -------
> 
> Instead of randomly rotating every cell, rotate random cells such that initial and final state are not same and minimum moves to win is equal to shuffle limit.
> 
> This will also make sure the highscore is impartial on every game.
> I am also thinking of committing new highscore method since this patch will make getting highscore impossible for some cases.
> 
> 
> This addresses bug 160470.
>     http://bugs.kde.org/show_bug.cgi?id=160470
> 
> 
> Diffs
> -----
> 
>   src/abstractgrid.cpp 63ed8b8 
>   src/globals.h 6df25a0 
> 
> Diff: http://git.reviewboard.kde.org/r/109880/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashwin Rajeev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130413/2bed1739/attachment-0001.html>