[Kde-games-devel] Review Request 109880: New shuffling algorithm

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109880/#review30562
-----------------------------------------------------------



src/abstractgrid.cpp
<http://git.reviewboard.kde.org/r/109880/#comment22747>

    This (initializing an array with a variable that is runtime dependant) is a gnu extension and not valid C++, use a QVector or something else


- Albert Astals Cid


On April 6, 2013, 9:55 a.m., Ashwin Rajeev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109880/
> -----------------------------------------------------------
> 
> (Updated April 6, 2013, 9:55 a.m.)
> 
> 
> Review request for KDE Games, Albert Astals Cid and Parker Coates.
> 
> 
> Description
> -------
> 
> While minimum moves to win is less than or equal to minimum number of cells in that particular difficulty level shuffle a random cell that is not yet shuffled.
> 
> This will also make sure the highscore is impartial on every game.
> I am also thinking of committing new highscore method since this patch will make getting highscore impossible for some cases.
> 
> 
> This addresses bug 160470.
>     http://bugs.kde.org/show_bug.cgi?id=160470
> 
> 
> Diffs
> -----
> 
>   src/abstractgrid.cpp 63ed8b8 
> 
> Diff: http://git.reviewboard.kde.org/r/109880/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashwin Rajeev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130406/482f0144/attachment.html>