[Kde-games-devel] Review Request 109827: Add custom game level
Albert Astals Cid
aacid at kde.org
Fri Apr 5 21:41:59 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109827/#review30528
-----------------------------------------------------------
Ship it!
>From the two remaining issues:
* Version increase: I'd say you've given a good enough reason to increase the version number
* Highscores for Custom Level: Ok, we already have a game with a subobtimal solution for Custom Highscores so no reason to block on that.
>From my side I think you can commit, maybe you can wait a day or two in case someone else has ay objection.
- Albert Astals Cid
On April 4, 2013, 9:35 p.m., Ashwin Rajeev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109827/
> -----------------------------------------------------------
>
> (Updated April 4, 2013, 9:35 p.m.)
>
>
> Review request for KDE Games and Albert Astals Cid.
>
>
> Description
> -------
>
> Custom game level where user can select size ( 3 - 11 ) and whether wrapping is needed.
>
> Feature: 221727
>
>
> This addresses bug 221727.
> http://bugs.kde.org/show_bug.cgi?id=221727
>
>
> Diffs
> -----
>
> doc/index.docbook b264e43
> src/CMakeLists.txt fbee0f6
> src/customgame.ui PRE-CREATION
> src/knetwalk.kcfg 19e6f97
> src/main.cpp 0113bcf
> src/mainwindow.h f5609e4
> src/mainwindow.cpp 7c1e47f
>
> Diff: http://git.reviewboard.kde.org/r/109827/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashwin Rajeev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130405/a715218f/attachment.html>
More information about the kde-games-devel
mailing list