[Kde-games-devel] Review Request 109813: Play sound when a terminal is connected

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109813/#review30330
-----------------------------------------------------------


To be honest i don't think forcing the updateConnections call is a nice idea, we're calling it twice now, What do you think about moving the play sound code to the loop you added in updateConnections? 

- Albert Astals Cid


On April 3, 2013, 8:18 a.m., Ashwin Rajeev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109813/
> -----------------------------------------------------------
> 
> (Updated April 3, 2013, 8:18 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> When a new terminal is connected play connect.wav along with turn.wav
> 
> 
> Diffs
> -----
> 
>   src/fielditem.h 91e1a33 
>   src/fielditem.cpp 3a4dcf1 
> 
> Diff: http://git.reviewboard.kde.org/r/109813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashwin Rajeev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130403/dc01d4ff/attachment.html>