[Kde-games-devel] Review Request 109813: Play sound when a terminal is connected

[Ashwin Rajeev]

> On April 2, 2013, 10:12 p.m., Albert Astals Cid wrote:
> > src/fielditem.cpp, line 206
> > <http://git.reviewboard.kde.org/r/109813/diff/1/?file=127304#file127304line206>
> >
> >     Are you sure you want to move this after checkIfGameEnded? Seems like something might break, have you checked it doesn't?

It is not causing any problem now. But i think old way is safer


- Ashwin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109813/#review30298
-----------------------------------------------------------


On April 1, 2013, 5:26 p.m., Ashwin Rajeev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109813/
> -----------------------------------------------------------
> 
> (Updated April 1, 2013, 5:26 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> When a new terminal is connected play connect.wav along with turn.wav
> 
> 
> Diffs
> -----
> 
>   src/fielditem.h 91e1a33 
>   src/fielditem.cpp 3a4dcf1 
> 
> Diff: http://git.reviewboard.kde.org/r/109813/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashwin Rajeev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130403/f4ca8fff/attachment.html>