[Kde-games-devel] kde-games-devel Digest, Vol 112, Issue 13
Kleag
kleag at free.fr
Fri Sep 21 18:07:48 UTC 2012
Le vendredi 21 septembre 2012 08:02:39 kde-games-devel-request at kde.org a écrit
:
> Send kde-games-devel mailing list submissions to
> kde-games-devel at kde.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
> https://mail.kde.org/mailman/listinfo/kde-games-devel
> or, via email, send a message with subject or body 'help' to
> kde-games-devel-request at kde.org
>
> You can reach the person managing the list at
> kde-games-devel-owner at kde.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of kde-games-devel digest..."
>
>
> Today's Topics:
>
> 1. Bug 304362 KsirK crashes on "new game" after one is already
> finished (Nemanja Hirsl)
> 2. Re: Bug 304362 KsirK crashes on "new game" after one is
> already finished (Roney Gomes)
> 3. Move to the Git Review Board (Roney Gomes)
> 4. Re: Move to the Git Review Board (Wolfgang Rohdewald)
> 5. Re: Move to the Git Review Board (Ian Wadham)
> 6. Re: Move to the Git Review Board (Wolfgang Rohdewald)
> 7. KMahjongg git (Christian Krippendorf)
> 8. Re: KMahjongg git (Wolfgang Rohdewald)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Thu, 20 Sep 2012 20:45:25 +0200
> From: Nemanja Hirsl <nemhirsl at gmail.com>
> To: kde-games-devel at kde.org
> Subject: [Kde-games-devel] Bug 304362 KsirK crashes on "new game"
> after one is already finished
> Message-ID:
> <CAAmU1+RYBCQzhS7mGvAiP1Jv_5o+iyhPfy6xWevXxgw=G2m3ow at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> Hi,
>
> I would like to get involved in KDE development especially in kdegames. Not
> so long ago I opened a bug (from subject) for ksirk game and now I believe
> I have a possible solution. Since this is my first try to contribute to KDE
> I would really appreciate any feedback.
> Probably Stefan and Gael are busy and don't have time to answer some of my
> questions, so I'm forwarding my email to the kde-games-devel list.
>
> Details are in forwarded email.
>
> Thanks in advance.
>
> Best regards,
> Nemanja
>
> ---------- Forwarded message ----------
> From: <nemhirsl at gmail.com>
> Date: Sun, Sep 16, 2012 at 9:53 PM
> Subject: Bug 304362 KsirK crashes on "new game" after one is already
> finished
> To: majewsky at gmx.net, kleag at free.fr
>
>
> Hi Stefan, Gael,
>
> I'm new to KDE and this is my first attempt to contribute to any project. I
> would really appreciate any feedback from you.
>
> Recently, I've opened a bug (from the subject) and now, after a couple of
> days of playing with the code and analyzing various situations, I've came
> up with possible solution (attached, see below for explanation).
>
> First, I would like to list all steps I did before I found possible
> solution:
> 1. I've pulled the code from git and successfully built it.
> 2. Enabled kdebug from kdebugdialog
> 3. run ksirk in gdb
> 4. Analyzed backtrace shown here:
> https://bugs.kde.org/show_bug.cgi?id=304362
> 5. Added some new kdebug printouts to make sure list iterators are OK:
> In GameAutomaton::removeAllPlayers all list items (KPlayer*) are OK before
> qDeleteAll call.
> 6. Code analysis:
> - PlayerList is list of KPlayer*;
> - Iterators became messed up in qDeleteAll (still crashing);
> - pulled out deletion from qDeleteAll to my own loop (still crashing);
> - KPlayer destructor analyzed - When object is deleted, it get pulled out
> from the game (playerList), modifying original playerList. This is the
> problem because iterators to a QList became invalid after any (insertion
> or) removal !
>
> In KPlayer::~KPlayer() see game()->playerDeleted(this);
> In KGame::playerDeleted(KPlayer *player) see
> systemRemovePlayer(player,false);
> in KGame::systemRemovePlayer(KPlayer* player,bool deleteit) see
> systemRemove(player,deleteit);
> Finally result = d->mPlayerList.removeAll(p);
>
> ***
> To prevent this crash qDeleteAll should not be called for lists modified in
> destructors (like in case of Kplayer). The solution I propose is to keep
> all possible cases working.
> ***
>
> Change I found in git on 2010-07-03 17:41:42 Refactoring: Simplify
> unnecessarily complicated deletion statements.
>
>
> There are also two more bugs (should be duplicates of each other):
> https://bugs.kde.org/show_bug.cgi?id=305000 andhttps://
> bugs.kde.org/show_bug.cgi?id=303142
> The reason for this crash is the same: qDeleteAll is called on Kplayer*
> list, but this time in libkdegames: void KGame::deletePlayers(). There I
> saw comment Stefan left, but maybe the same solution could be applied in
> this case?
>
>
> To sum up my questions:
> Do you agree with proposed solution? If not, what should I change?
> Can this be applied to bug in libkdegames?
>
> Again, I would really appreciate any feedback.
> Thank you for your time and help.
>
> Best regards,
> Nemanja
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120920/af0b644
> 3/attachment-0001.html> -------------- next part --------------
> A non-text attachment was scrubbed...
> Name: gameautomaton.diff
> Type: text/x-patch
> Size: 854 bytes
> Desc: not available
> URL:
> <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120920/af0b644
> 3/attachment-0001.diff>
>
> ------------------------------
>
> Message: 2
> Date: Thu, 20 Sep 2012 20:26:40 -0300
> From: Roney Gomes <roney477 at gmail.com>
> To: KDE games development <kde-games-devel at kde.org>
> Subject: Re: [Kde-games-devel] Bug 304362 KsirK crashes on "new game"
> after one is already finished
> Message-ID:
> <CAGZyHOVvo63YZz-v1XZRdn2PsCUNRh9Ew3u-pVnJtmwCL1SVuA at mail.gmail.com>
> Content-Type: text/plain; charset=UTF-8
>
> On Thu, Sep 20, 2012 at 3:45 PM, Nemanja Hirsl <nemhirsl at gmail.com> wrote:
> > Hi,
>
> Hello Nemanja.
>
> First of all, thanks for helping. Bug solving is always appreciated. :-)
>
> > I would like to get involved in KDE development especially in kdegames.
> > Not
> > so long ago I opened a bug (from subject) for ksirk game and now I believe
> > I have a possible solution. Since this is my first try to contribute to
> > KDE I would really appreciate any feedback.
>
> So, be welcome. :-)
>
> But before we start to review your code please, go to
> svn.reviewboard.org and set up a new account for you. After that, you
> can go ahead and submit your patch to KDE's review system.
>
> Review Board is an awesome way of getting feedback and revision for
> your code, that's the way any patch is reviewed by the KDE Games team.
>
> We moved to Git quite recently, so we still have no entries on
> git.reviewboard.kde.org (that's why we still need to do reviews
> through svn.reviewboard.kde.org).
>
> To upload your diff, follow the steps below:
>
> 1. Go to "New Review Request".
> 2. Select "kde" on the "Repository" field.
> 3. On the "Base Directory" field paste "/trunk/KDE/kdegames/ksirk"
> (this was the path to ksirk's repo on the old svn server, don't
> include the quotes).
> 4. Upload your diff.
> 5. After the upload is done type "kdegames" (without quotes) on the
> "Groups" field.
> 6. Describe your changes and the testing done.
> 7. Publish the request.
>
> If you have any trouble regarding any of these steps, feel free to ask for
> help.
> > Can this be applied to bug in libkdegames?
>
> If the bug is present in more than one kdegames component, than
> please, publish two different review requests, with the proper diffs.
>
> Best regards, Roney.
>
>
> ------------------------------
>
> Message: 3
> Date: Thu, 20 Sep 2012 20:30:33 -0300
> From: Roney Gomes <roney477 at gmail.com>
> To: KDE games development <kde-games-devel at kde.org>
> Subject: [Kde-games-devel] Move to the Git Review Board
> Message-ID:
> <CAGZyHOV2sCVKtOzinDFVFLYwf6Vz8zdQUn-nNGuUUZMpOL7N0Q at mail.gmail.com>
> Content-Type: text/plain; charset=UTF-8
>
> Hello there.
>
> Has anyone talked to the sysadmin people about the inclusion of the
> games on the Git Review Board? If not, what do I have to solve that,
> just ask?
>
> Best regards, Roney.
>
>
> ------------------------------
>
> Message: 4
> Date: Fri, 21 Sep 2012 08:00:35 +0200
> From: Wolfgang Rohdewald <wolfgang at rohdewald.de>
> To: kde-games-devel at kde.org
> Cc: d at vidsolbach.de
> Subject: Re: [Kde-games-devel] Move to the Git Review Board
> Message-ID: <12040746.mZpGtvaJhM at i5>
> Content-Type: text/plain; charset="us-ascii"
>
> Am Donnerstag, 20. September 2012, 20:30:33 schrieb Roney Gomes:
> > Has anyone talked to the sysadmin people about the inclusion of the
> > games on the Git Review Board? If not, what do I have to solve that,
> > just ask?
>
> https://bugs.kde.org/show_bug.cgi?id=306027
>
> see last two comments
>
> > Am Donnerstag, 20. September 2012, 20:30:33 schrieb Roney Gomes:
> >> Has anyone talked to the sysadmin people about the inclusion of the
> >> games on the Git Review Board? If not, what do I have to solve that,
> >> just ask?
> >
> > https://bugs.kde.org/show_bug.cgi?id=306027
> >
> > see last two comments
>
> I just get a message to say I am not authorised to access that bug ? :-)
> even when I am logged in to BKO ? Been having it for weeks.
> I imagined back then that it would be unlocked after the move to GIT ...
>
> Cheers, Ian W.
>
>
>
> ------------------------------
>
> Message: 6
> Date: Fri, 21 Sep 2012 08:16:43 +0200
> From: Wolfgang Rohdewald <wolfgang at rohdewald.de>
> To: kde-games-devel at kde.org
> Cc: Ian Wadham <iandw.au at gmail.com>
> Subject: Re: [Kde-games-devel] Move to the Git Review Board
> Message-ID: <1487992.pUAf0vdekp at i5>
> Content-Type: text/plain; charset="utf-8"
>
> Am Freitag, 21. September 2012, 16:10:50 schrieb Ian Wadham:
> > On 21/09/2012, at 4:00 PM, Wolfgang Rohdewald wrote:
> > > Am Donnerstag, 20. September 2012, 20:30:33 schrieb Roney Gomes:
> > >> Has anyone talked to the sysadmin people about the inclusion of the
> > >> games on the Git Review Board? If not, what do I have to solve that,
> > >> just ask?
> > >
> > > https://bugs.kde.org/show_bug.cgi?id=306027
> > >
> > > see last two comments
> >
> > I just get a message to say I am not authorised to access that bug ? :-)
>
> I forgot - sysadmin bug, accessible for sysadmins and for requester (me).
> In short, reviewboards should have been done by sysadmins but have only
> been done for kajongg. I reopened the bug report today.
>
> > All ready for git with kmahjongg?
>
> yes
>
> > Anything i should do?
>
> if you want to become admin of a game git repo, please tell us.
>
> > Moveing to git complete?
>
> yes. The git reviewboard will hopefully be ready soon.
>
> http://community.kde.org/KDE_Games/Git_Conversion_Progress
More information about the kde-games-devel
mailing list