[Kde-games-devel] Bug 304362 KsirK crashes on "new game" after one is already finished

[Roney Gomes]

On Thu, Sep 20, 2012 at 3:45 PM, Nemanja Hirsl <nemhirsl at gmail.com> wrote:
> Hi,

Hello Nemanja.

First of all, thanks for helping. Bug solving is always appreciated. :-)

> I would like to get involved in KDE development especially in kdegames. Not
> so long ago I opened a bug (from subject) for ksirk game and now I believe I
> have a possible solution. Since this is my first try to contribute to KDE I
> would really appreciate any feedback.

So, be welcome. :-)

But before we start to review your code please, go to
svn.reviewboard.org and set up a new account for you. After that, you
can go ahead and submit your patch to KDE's review system.

Review Board is an awesome way of getting feedback and revision for
your code, that's the way any patch is reviewed by the KDE Games team.

We moved to Git quite recently, so we still have no entries on
git.reviewboard.kde.org (that's why we still need to do reviews
through svn.reviewboard.kde.org).

To upload your diff, follow the steps below:

1. Go to "New Review Request".
2. Select "kde" on the "Repository" field.
3. On the "Base Directory" field paste "/trunk/KDE/kdegames/ksirk"
(this was the path to ksirk's repo on the old svn server, don't
include the quotes).
4. Upload your diff.
5. After the upload is done type "kdegames" (without quotes) on the
"Groups" field.
6. Describe your changes and the testing done.
7. Publish the request.

If you have any trouble regarding any of these steps, feel free to ask for help.

> Can this be applied to bug in libkdegames?

If the bug is present in more than one kdegames component, than
please, publish two different review requests, with the proper diffs.

Best regards, Roney.