[Kde-games-devel] Review Request: add option to allow adjacent ships

[Jaime Torres Amate]

> On Oct. 12, 2012, 10:49 p.m., Roney Gomes wrote:
> > Hello Jaime.
> > 
> > I've applied your patch and did some tests, here go my conclusions:
> > 
> > 1. A player is allowed to change the current rule at any time, which allows the player to, let's say, cheat at will. I think that this rule should be chosen before each game, and could be changed only when the current game is over.
> > 
> > 2. In a network game, players can play under different rules. One possible way to solve this would be to add a QCheckBox in the dialog which appears when a player decides to host a new game. This way the host would decide whether the match will be given under the new rule or not.
> > 
> > My idea, aiming to make the user experience consistent through both game modes, is:
> > 
> > a) Prompt a dialog to the user before a single player match. In this dialog he/she would change his/her nickname, set the AI difficulty and the rule to player under.
> > 
> > b) Prompt a dialog to the user before a network match, in order to let him set his/her nickname, the port to make the connection and the game rule.
> > 
> > Notice that in "a" we are going to make the status bar useless, since it's only feature is to change the AI level. So, if we are really going to add this new feature, which is very likely, some redesign is required and the network issue definitely have to be solved. 
> > 
> > These are my opinions. If you have a different approach to the issues pointed above, let me know about it.
> > 
> > Best regards.
> 
> Jaime Torres Amate wrote:
>     What about this idea (I just don't like the idea of pressing two buttons for every game)?
>     
>     Instead of a dialog, showing/settings all this things in the presentation screen (could be over a translucent background, like in kpatience or khangman winner/looser), this way, only a button is required.
>     
>     In any case, I think this could be a question for the usability team.
> 
> Roney Gomes wrote:
>     I understand your point. In this case we could the following: instead of prompting a dialog in the single player mode, we would let the game the way it already is, i.e. the player can allow/disallow the rule via the settings menu.
>     
>     Now, regarding the network mode, we'd have to add an option in the dialog which appears before each game. This option would reflect the decision made by the player in the single player mode, it will be there for the case in which the player decides to change it.
>     
>     So, if we agree about that, a few things remain to be made:
>     
>     1. Only allow the player to change this rule before a new game.
>     2. Add a new option in the network dialog.
>     3. Enforce the rule in the network mode.
>     
>     What you think?

Ok. I agree. I'll work on it the next week.
Just a question. In a network game. Who will impose the game type, the server or the client?
I think it should be in the server.


- Jaime Torres


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106772/#review20234
-----------------------------------------------------------


On Oct. 11, 2012, 8:15 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106772/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 8:15 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Add the option to allow adjacent ships.
> When it is not checked, the ships can not be placed adjacent.
> 
> 
> This addresses bug 168659.
>     http://bugs.kde.org/show_bug.cgi?id=168659
> 
> 
> Diffs
> -----
> 
>   src/battlefield.cpp 32aa525 
>   src/kbattleship.kcfg b615f30 
>   src/kbattleshipui.rc 7c51ac6 
>   src/mainwindow.cpp a7cceeb 
>   src/playfield.h 56934dc 
>   src/playfield.cpp 61c0ac6 
>   src/ship.h 5e35f1a 
>   src/ship.cpp 86858d9 
> 
> Diff: http://git.reviewboard.kde.org/r/106772/diff/
> 
> 
> Testing
> -------
> 
> tested locally.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121029/ba731fda/attachment.html>