[Kde-games-devel] Review Request: Fix for bug 27512

[Gaël de Chalendar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106769/#review20173
-----------------------------------------------------------


This in fact is bug #272512. Thanks for your patch. I'll try it as soon as possible.

- Gaël de Chalendar


On Oct. 8, 2012, 4:37 p.m., Del Only wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106769/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2012, 4:37 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This bug has been present for years now, so I finally got around to chasing it 
> down. It is always reproducible across distributions and KDE releases, and is 
> rather critical for Ksirk. I posted the patch on the bug tracker, but I assume 
> the mailing list is the appropriate place.
> 
> Anyway, the bug is caused by the slot SlideClose being triggered twice in 
> InvasionSlilder.cpp. Hence, the number on the slider (total number of armies 
> to move minus three) is moved twice. I removed the duplicate entry, and this 
> seems to have fixed the bug.
> 
> 
> Diffs
> -----
> 
>   ksirk/Dialogs/InvasionSlider.cpp 724c8d9 
> 
> Diff: http://git.reviewboard.kde.org/r/106769/diff/
> 
> 
> Testing
> -------
> 
> Couple of hours of playing. No trace of the bug.
> 
> 
> Thanks,
> 
> Del Only
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121010/abc1b6ba/attachment.html>