[Kde-games-devel] Review Request: Solution for Bug 308889: "Can not change the difficulty level after starting the first game."

[Albert Astals Cid]

> On Nov. 18, 2012, 9:38 p.m., Albert Astals Cid wrote:
> > Feels totally unexpected that if I change the difficulty just after starting the program the game starts
> 
> Roney Gomes wrote:
>     Humm... thought it would be more practical this way. I mean, if one is going to change the difficulty level before the game has started it's because she/he wouldn't like to start a new game just to change its difficulty.
>     
>     What's the behavior you expected? I wanna solve this bug once for all. :-)

To be honest, if i don't have a game started and i change the difficulty, i expect nothing to happen (other than the diffficulty changing of course :D)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107084/#review22190
-----------------------------------------------------------


On Nov. 18, 2012, 5:48 p.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107084/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2012, 5:48 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Solves the bug, allowing the player to change the difficulty level at any time.
> 
> 
> This addresses bug 308889.
>     http://bugs.kde.org/show_bug.cgi?id=308889
> 
> 
> Diffs
> -----
> 
>   gamewidget.h ade3d64 
>   gamewidget.cpp 3e7b12e 
>   mainwindow.cpp 5ab7e8c 
> 
> Diff: http://git.reviewboard.kde.org/r/107084/diff/
> 
> 
> Testing
> -------
> 
> The difficulty was changed in different levels of KBounce. It was also verified whether a restored game applies the difficulty set in a previous execution of the game.
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121119/52c97fd5/attachment.html>