[Kde-games-devel] Review Request: add option to allow adjacent ships

[Roney Gomes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106772/#review22182
-----------------------------------------------------------


Hi Jaime, your patch works quite nicely, thanks.

Despite your patch perform a good work, I think there's still space for a last improvement. What do you think about notifying the players whether adjacent ships are allowed or not in the chat widget? Something like what we already have about the players' nicknames.

It would be a simple message containing a string like "Adjacent ships are allowed." right after the beginning of a game.

- Roney Gomes


On Nov. 6, 2012, 12:03 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106772/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2012, 12:03 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Add the option to allow adjacent ships.
> When it is not checked, the ships can not be placed adjacent.
> 
> 
> This addresses bug 168659.
>     http://bugs.kde.org/show_bug.cgi?id=168659
> 
> 
> Diffs
> -----
> 
>   src/message.cpp 59de527 
>   src/message.h 2757cf7 
>   src/mainwindow.cpp a7cceeb 
>   src/battlefield.cpp 32aa525 
>   src/kbattleship.kcfg b615f30 
>   src/kbattleshipui.rc 7c51ac6 
>   src/networkentity.h c82bfbd 
>   src/networkentity.cpp 3367389 
>   src/playfield.h 56934dc 
>   src/playfield.cpp 61c0ac6 
>   src/protocol.cpp 791179b 
>   src/ship.h 5e35f1a 
>   src/ship.cpp 86858d9 
> 
> Diff: http://git.reviewboard.kde.org/r/106772/diff/
> 
> 
> Testing
> -------
> 
> tested locally.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121118/bff08941/attachment.html>