[Kde-games-devel] Review Request: Sets the current difficulty level of a game only after the proper signals have been emitted.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107054/#review21316
-----------------------------------------------------------


I don't think this makes sense, you say "something changed", but then if i ask the class with the getter, it has the old value, this is not the typical behaviour of Qt classes.

- Albert Astals Cid


On Oct. 26, 2012, 1:11 p.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107054/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2012, 1:11 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Allows the game using this library compare the level selected via the widget of level selection with the current difficulty of the game, giving more flexibility to the events triggered by the selectedLevelChanged() and currentLevelChanged() signals.
> 
> This change was necessary to solve the bug 308380 of KNavalBattle.
> 
> 
> This addresses bug 308380.
>     http://bugs.kde.org/show_bug.cgi?id=308380
> 
> 
> Diffs
> -----
> 
>   kgdifficulty.cpp b94cce0 
> 
> Diff: http://git.reviewboard.kde.org/r/107054/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121101/d5f24cae/attachment-0001.html>