[Kde-games-devel] Review Request: Porting Kapman from Phonon to KgSound

[Roney Gomes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6914/
-----------------------------------------------------------

(Updated March 23, 2012, 2:20 p.m.)


Review request for KDE Games.


Changes
-------

The sounds are no more being doubly initialized. This time, the calls to KgSound's constructor are made in the initializer list.


Description
-------

I've ported kapman to KgSound as requested in the mailing list. The files changed were game.cpp and game.h.


Diffs (updated)
-----

  /trunk/KDE/kdegames/kapman/game.h 1286463 
  /trunk/KDE/kdegames/kapman/game.cpp 1286463 

Diff: http://svn.reviewboard.kde.org/r/6914/diff/


Testing
-------

I've played and observed whether the sounds were been played in the proper situations.


Thanks,

Roney Gomes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120323/5521f550/attachment.html>