[Kde-games-devel] git conversion kmahjongg

[Frederik Schwarzer]

Am Dienstag, 13. März 2012, 23:50:29 schrieb Mathias Kraus:
> Am Dienstag, 13. März 2012, 21:20:59 schrieb Stefan Majewsky:
> > On Tue, Mar 13, 2012 at 8:23 PM, Christian Krippendorf
> > 
> > <Coding at christian-krippendorf.de> wrote:
> > > find_package(KDE4 REQUIRED)
> > > include_directories (${QDBUS_INCLUDE_DIRS} ${CMAKE_SOURCE_DIR}
> > > ${CMAKE_BINARY_DIR} ${KDE4_INCLUDES})
> > 
> > I think the actual idiom is:
> > 
> > find_package(KDE4 REQUIRED)
> > include(KDE4Defaults)
> > include_directories(${KDE4_INCLUDES})
> 
> well, in granatier I do just the following and it works quite good
> 
> if (NOT KDE4_FOUND)
>   find_package(KDE4 REQUIRED)
>   include(KDE4Defaults)
>   include_directories(${KDE4_INCLUDES})
> endif (NOT KDE4_FOUND)

I think we should be a bit more explicit. Defining a variable in the 
kdegames/CMakeLists.txt and looking for it in the games's cmake files 
sounds right.

Regards