[Kde-games-devel] Review Request: Porting Bomber from KGameCanvas to QGraphicsView

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6908/#review10720
-----------------------------------------------------------


Stefan touched on some of the implementation issues, but I agree that it looks pretty good on the whole.

The following are several small issues with the patch.


trunk/KDE/kdegames/bomber/src/board.h
<http://svn.reviewboard.kde.org/r/6908/#comment13247>

    Whitespace and format issues.



trunk/KDE/kdegames/bomber/src/board.h
<http://svn.reviewboard.kde.org/r/6908/#comment13248>

    Empty line before and after, please.



trunk/KDE/kdegames/bomber/src/board.h
<http://svn.reviewboard.kde.org/r/6908/#comment13249>

    Whitespace issue.



trunk/KDE/kdegames/bomber/src/board.h
<http://svn.reviewboard.kde.org/r/6908/#comment13250>

    Unrelated change.



trunk/KDE/kdegames/bomber/src/board.h
<http://svn.reviewboard.kde.org/r/6908/#comment13251>

    
    Whitespace issue.



trunk/KDE/kdegames/bomber/src/board.cpp
<http://svn.reviewboard.kde.org/r/6908/#comment13252>

    Whitespace issues.



trunk/KDE/kdegames/bomber/src/board.cpp
<http://svn.reviewboard.kde.org/r/6908/#comment13260>

    Whitespace issue.



trunk/KDE/kdegames/bomber/src/board.cpp
<http://svn.reviewboard.kde.org/r/6908/#comment13261>

    Unrelated change.



trunk/KDE/kdegames/bomber/src/board.cpp
<http://svn.reviewboard.kde.org/r/6908/#comment13262>

    Unrelated change.



trunk/KDE/kdegames/bomber/src/bomberwidget.h
<http://svn.reviewboard.kde.org/r/6908/#comment13263>

    Whitespace issue.



trunk/KDE/kdegames/bomber/src/bomberwidget.cpp
<http://svn.reviewboard.kde.org/r/6908/#comment13264>

    Whitespace issue.



trunk/KDE/kdegames/bomber/src/building.cpp
<http://svn.reviewboard.kde.org/r/6908/#comment13265>

    Unused header?



trunk/KDE/kdegames/bomber/src/explodable.h
<http://svn.reviewboard.kde.org/r/6908/#comment13266>

    Line removed for no reason.



trunk/KDE/kdegames/bomber/src/explodable.cpp
<http://svn.reviewboard.kde.org/r/6908/#comment13267>

    Unused header. (By the way, KDebug has more features than QDebug, so you might want to try it in the future.)


- Parker Coates


On March 12, 2012, 4:47 p.m., Mehmet Emre wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6908/
> -----------------------------------------------------------
> 
> (Updated March 12, 2012, 4:47 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> I've ported bomber to QGraphicsView as requested here: http://techbase.kde.org/Projects/Games/Porting. I've made some modifications on the classes below:
> - Explodable
> - BomberBoard
> - BomberGameWidget
> - Building
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/bomber/src/board.h 1284898 
>   trunk/KDE/kdegames/bomber/src/board.cpp 1284898 
>   trunk/KDE/kdegames/bomber/src/bomberwidget.h 1284898 
>   trunk/KDE/kdegames/bomber/src/bomberwidget.cpp 1284898 
>   trunk/KDE/kdegames/bomber/src/building.h 1284898 
>   trunk/KDE/kdegames/bomber/src/building.cpp 1284898 
>   trunk/KDE/kdegames/bomber/src/explodable.h 1284898 
>   trunk/KDE/kdegames/bomber/src/explodable.cpp 1284898 
> 
> Diff: http://svn.reviewboard.kde.org/r/6908/diff/
> 
> 
> Testing
> -------
> 
> I've done these tests and solved the problems that I've bumped into:
> - Played bomber's first two levels.
> - Paused the game
> - Changed settings during the game and while game is paused.
> 
> 
> Thanks,
> 
> Mehmet Emre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120312/b69b0271/attachment-0001.html>