[Kde-games-devel] Review Request: Fix DLL linkage of lskat on parts that had been brought from old libkdegames.

Parker Coates coates at kde.org
Wed Jul 25 11:28:40 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/7009/#review10888
-----------------------------------------------------------

Ship it!


Whoops! This was my mistake. Thank you very much for the fix.

- Parker Coates


On July 24, 2012, 10:23 p.m., Andrius Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/7009/
> -----------------------------------------------------------
> 
> (Updated July 24, 2012, 10:23 p.m.)
> 
> 
> Review request for kde-windows and KDE Games.
> 
> 
> Description
> -------
> 
> Fix DLL linkage of lskat on parts that had been brought from old libkdegames (Removal of EXPORTS due to direct linking).
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/lskat/src/fromlibkdegames/cardcache.h 1307602 
>   trunk/KDE/kdegames/lskat/src/fromlibkdegames/carddeckinfo.h 1307602 
>   trunk/KDE/kdegames/lskat/src/fromlibkdegames/kcarddialog.h 1307602 
> 
> Diff: http://svn.reviewboard.kde.org/r/7009/diff/
> 
> 
> Testing
> -------
> 
> Tested using MSVC 2010.
> 
> 
> Thanks,
> 
> Andrius Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120725/e3de7724/attachment.html>


More information about the kde-games-devel mailing list