[Kde-games-devel] Review Request: Check for NULL return from m_map->sector(m_selection).

[Yuri Chornoivan]

> On July 9, 2012, 6:44 p.m., Albert Astals Cid wrote:
> > The code looks good, but the bug number points to something different. Is there any bug number that covers this?

It is bug 293404 (the number was mistakingly taken from the attachment).


- Yuri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/7005/#review10866
-----------------------------------------------------------


On July 6, 2012, 2:33 a.m., Michael Reeves wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/7005/
> -----------------------------------------------------------
> 
> (Updated July 6, 2012, 2:33 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Check for NULL return from m_map->sector(m_selection) to prevent crashing on clicking locations just outside the minimap.
> 
> 
> This addresses bug 68541.
>     https://bugs.kde.org/show_bug.cgi?id=68541
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.8/kdegames/konquest/minimapview.cc 1304213 
> 
> Diff: http://svn.reviewboard.kde.org/r/7005/diff/
> 
> 
> Testing
> -------
> 
> Verrified that minimap works correctly after the patch.
> 
> 
> Thanks,
> 
> Michael Reeves
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120709/8f26744b/attachment.html>