[Kde-games-devel] Review Request: assert in kgdifficulty if level range begins with RidiculouslyEasy

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6979/#review10849
-----------------------------------------------------------

Ship it!


Looks okay, though I would rather split this into more asserts with more relevant descriptions.

- Stefan Majewsky


On June 10, 2012, 8:56 p.m., Mathias Kraus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6979/
> -----------------------------------------------------------
> 
> (Updated June 10, 2012, 8:56 p.m.)
> 
> 
> Review request for KDE Games and Stefan Majewsky.
> 
> 
> Description
> -------
> 
> There is an assert in kgdifficulty, if the level range set by addStandardLevelRange begins with RidiculouslyEasy.
> This will crash bovo on startup.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/libkdegames/kgdifficulty.cpp 1299641 
> 
> Diff: http://svn.reviewboard.kde.org/r/6979/diff/
> 
> 
> Testing
> -------
> 
> Bovo doesn't crash anymore.
> No effect on other games.
> 
> 
> Thanks,
> 
> Mathias Kraus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120702/36a3cad9/attachment.html>