[Kde-games-devel] Review Request: kmahjongg: Feature Request of a fast selection when selecting unmatch tiles

[Christian Krippendorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6836/
-----------------------------------------------------------

(Updated Jan. 11, 2012, 7:02 p.m.)


Review request for KDE Games.


Changes
-------

So, ... ready :D

This patch adds 3 different selection-modes.

These modes will be effective when a user has a tile already selected and selects a different second tile that does not match the actual one. Then following can happen:
 - The first tile keeps selected and the second wont't get selected.
 - The second tile gets selected and the first one will be unselected.
 - Both tiles gets unselected.

They don't effect clicking on the same tile. Clicking on a already selected tile, will deselect it. Maybe a later checkbox option will give the user the optionen to handle this in a different way.

I also don't know if the text parts are ok in the gui. Also please test the code. Maybe this is also a good idea for kshisen etc. as it lets the user decide how to handle when clicking on an unmatching tile.

Greez


Description
-------

Bug List Link: https://bugs.kde.org/show_bug.cgi?id=286878


Diffs (updated)
-----

  trunk/KDE/kdegames/kmahjongg/boardwidget.h 1273080 
  trunk/KDE/kdegames/kmahjongg/boardwidget.cpp 1273080 
  trunk/KDE/kdegames/kmahjongg/kmahjongg.cpp 1273080 
  trunk/KDE/kdegames/kmahjongg/kmahjongg.kcfg 1273080 
  trunk/KDE/kdegames/kmahjongg/settings.ui 1273080 

Diff: http://svn.reviewboard.kde.org/r/6836/diff/diff


Testing
-------


Thanks,

Christian Krippendorf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120111/c9511bfd/attachment.html>