[Kde-games-devel] Review Request: kmahjongg: Undo after won is allowed

[Christian Krippendorf]

> On Dec. 14, 2011, 1:36 p.m., Frederik Schwarzer wrote:
> > trunk/KDE/kdegames/kmahjongg/boardwidget.cpp, line 404
> > <http://svn.reviewboard.kde.org/r/6841/diff/2/?file=47251#file47251line404>
> >
> >     Hmm, I am not very happy with the message. What about: "You have finished this board, there is nothing to be undone"?
> >     
> >     Maybe a native speaker could give advice here.
> 
> Ian Wadham wrote:
>     How about "Cannot undo: you have finished this puzzle."?
>     
>     Both of the previous suggestions would be good English, but "No undo allowed" is a little impolite and "game" gets us into that "What is a game?" argument. Is it just the puzzle you are on or is it the whole KMahjongg session? English tends to be ambiguous.
> 
> Christian Krippendorf wrote:
>     I don't think so realted to "game". In KMahjongg i can choose a new game on "Game" -> "New" und also a special "Game number" so i think that "game" isn't that bad. I would prefer "game" rather than "puzzle".
>     
>     "Cannot undo: you have finished this game." <- That sounds good to me.
> 
> Ian Wadham wrote:
>     OK. Coder decides.
> 
> Christian Krippendorf wrote:
>     Finally code ok for commiting?
> 
> Albert Astals Cid wrote:
>     Wondering if it would be better just disabling the undo action?
> 
> Frederik Schwarzer wrote:
>     Umm, right. I agree here. In KShisen I do it like that.
>     
>     void App::updateItems()
>     {
>         if (m_board->isOver()) {
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Undo))->setEnabled(false);
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Redo))->setEnabled(false);
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Pause))->setEnabled(false);
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Hint))->setEnabled(false);
>         } else if (m_board->isPaused()) {
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Undo))->setEnabled(false);
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Redo))->setEnabled(false);
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Restart))->setEnabled(false);
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Pause))->setChecked(true);
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Hint))->setEnabled(false);
>         } else if (m_board->isStuck()) {
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Pause))->setEnabled(false);
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Hint))->setEnabled(false);
>         } else {
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Undo))->setEnabled(m_board->canUndo());
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Redo))->setEnabled(m_board->canRedo());
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Restart))->setEnabled(m_board->canUndo());
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Pause))->setEnabled(true);
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Pause))->setChecked(false);
>             actionCollection()->action(KStandardGameAction::name(KStandardGameAction::Hint))->setEnabled(true);
>         }   
>     }
>
> 
> Christian Krippendorf wrote:
>     Oh no please nothing like that. Mauricio included some state event changings, so i used them for making the button disabled.

Ping!


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6841/#review10573
-----------------------------------------------------------


On Jan. 5, 2012, 9:20 p.m., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6841/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2012, 9:20 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Bug List Link: https://bugs.kde.org/show_bug.cgi?id=215352
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmahjongg/kmahjongg.h 1271895 
>   trunk/KDE/kdegames/kmahjongg/kmahjongg.cpp 1271895 
>   trunk/KDE/kdegames/kmahjongg/kmahjonggui.rc 1271895 
> 
> Diff: http://svn.reviewboard.kde.org/r/6841/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120106/e1abe35b/attachment.html>