[Kde-games-devel] Review Request: kmahjongg: Feature Request of a fast selection when selecting unmatch tiles

[Christian Krippendorf]

> On Nov. 25, 2011, 6:48 p.m., Wolfgang Rohdewald wrote:
> > trunk/KDE/kdegames/kmahjongg/settings.ui, line 1
> > <http://svn.reviewboard.kde.org/r/6836/diff/1/?file=47234#file47234line1>
> >
> >     why is this change needed for your new feature?
> >     
> >     if this is just a cleanup or if you want to bring the source up to modern standards, IMHO that should be a different commit like "cleanup for settings.ui". What about gametype.ui - shouldn't it get the same change?
> >     
> >     I could imagine there are other changes in this file which are not strictly needed for your new feature.

Ping!


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6836/#review10483
-----------------------------------------------------------


On Nov. 25, 2011, 7:27 p.m., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6836/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2011, 7:27 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Bug List Link: https://bugs.kde.org/show_bug.cgi?id=286878
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.cpp 1265765 
>   trunk/KDE/kdegames/kmahjongg/kmahjongg.kcfg 1265765 
>   trunk/KDE/kdegames/kmahjongg/settings.ui 1265765 
> 
> Diff: http://svn.reviewboard.kde.org/r/6836/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120106/56c86215/attachment-0001.html>