[Kde-games-devel] Review Request: kmahjongg: timer should stop while window is minimized

Frederik Schwarzer schwarzer at kde.org
Thu Jan 5 12:32:30 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6838/#review10616
-----------------------------------------------------------



trunk/KDE/kdegames/kmahjongg/kmahjongg.cpp
<http://svn.reviewboard.kde.org/r/6838/#comment12814>

    Because you asked:
    - use { and } even if the block contains only one line (not sure if it is part of the guidelines but in general it is a good idea)
    - indent by 4 spaces


- Frederik Schwarzer


On Nov. 25, 2011, 7:31 p.m., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6838/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2011, 7:31 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Bug List Link: https://bugs.kde.org/show_bug.cgi?id=238903
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmahjongg/kmahjongg.h 1265765 
>   trunk/KDE/kdegames/kmahjongg/kmahjongg.cpp 1265765 
> 
> Diff: http://svn.reviewboard.kde.org/r/6838/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120105/ef710dfa/attachment.html>


More information about the kde-games-devel mailing list