[Kde-games-devel] Review Request: kmahjongg: add random layout feature

[Christian Krippendorf]

> On Jan. 2, 2012, 7:59 p.m., Albert Astals Cid wrote:
> > trunk/KDE/kdegames/kmahjongg/kmahjongglayoutselector.cpp, line 127
> > <http://svn.reviewboard.kde.org/r/6840/diff/3/?file=47442#file47442line127>
> >
> >     Do you think it makes sense to you remove this slot connection and connect directly to widgetNoRandom::setDisabled in the ui file?

I really don't like such direct connections. As they are so much hidden. But cause this is a community project and u all want to have it like this. No problem. Just tell again that u want it and it will happen. :)


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6840/#review10600
-----------------------------------------------------------


On Dec. 28, 2011, 8:47 p.m., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6840/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2011, 8:47 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Bug List Link: https://bugs.kde.org/show_bug.cgi?id=241663
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.h 1270752 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.cpp 1270752 
>   trunk/KDE/kdegames/kmahjongg/gametype.ui 1270752 
>   trunk/KDE/kdegames/kmahjongg/kmahjongg.kcfg 1270752 
>   trunk/KDE/kdegames/kmahjongg/kmahjongglayoutselector.h 1270752 
>   trunk/KDE/kdegames/kmahjongg/kmahjongglayoutselector.cpp 1270752 
> 
> Diff: http://svn.reviewboard.kde.org/r/6840/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120104/e3ba61a7/attachment.html>