[Kde-games-devel] Review Request: Provision of viewing and adding dates for high scores in Kiriki

[Albert Astals Cid]

> On Feb. 26, 2012, 9:15 p.m., Albert Astals Cid wrote:
> > /trunk/KDE/kdegames/kiriki/src/kiriki.cpp, line 264
> > <http://svn.reviewboard.kde.org/r/6905/diff/1/?file=47675#file47675line264>
> >
> >     This remove(0,4) looks that it will break with any other language that doesn't do what you want. This can't be commited. Please pass toString the format you want
> 
> Arjun Basu wrote:
>     The standard QDate stores the day as well. It felt unnecessary and also it was messing up the display of the KScoreDialog, so I used the remove(0,4) to remove the day from the datestring.
>     I didn't get your point very clearly, can you please clarify

What if the language I am using does not use 4 characters for the day?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6905/#review10709
-----------------------------------------------------------


On Feb. 26, 2012, 8:33 a.m., Arjun Basu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6905/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2012, 8:33 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> In Kiriki, now there is an extra Date Field in the High Scores Dialog. Also the date is recorded whenever a new high score is generated.
> . This is in response to this bug report https://bugs.kde.org/show_bug.cgi?id=236656
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1282152 
> 
> Diff: http://svn.reviewboard.kde.org/r/6905/diff/
> 
> 
> Testing
> -------
> 
> Yes, I have tested the changes and it is working perfectly.
> 
> 
> Screenshots
> -----------
> 
> The High Scores Dialog
>   http://svn.reviewboard.kde.org/r/6905/s/625/
> New High Score
>   http://svn.reviewboard.kde.org/r/6905/s/626/
> 
> 
> Thanks,
> 
> Arjun Basu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120227/51bbfe1d/attachment.html>