[Kde-games-devel] Review Request: remove KGGZ dependency from KReversi

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6897/#review10669
-----------------------------------------------------------

Ship it!


Looks good.  Just check the question below, ok?


trunk/KDE/kdegames/kreversi/CMakeLists.txt
<http://svn.reviewboard.kde.org/r/6897/#comment12985>

    Shouldn't ${KGGZGAMES_LIBS} be removed too?


- Inge Wallin


On Feb. 10, 2012, 7:04 p.m., Stefan Majewsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6897/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2012, 7:04 p.m.)
> 
> 
> Review request for KDE Games and Inge Wallin.
> 
> 
> Description
> -------
> 
> As discussed on kde-games-devel@, I'm starting to remove KGGZ from kdegames.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kreversi/CMakeLists.txt 1278817 
>   trunk/KDE/kdegames/kreversi/kreversigame.h 1278817 
>   trunk/KDE/kdegames/kreversi/kreversigame.cpp 1278817 
>   trunk/KDE/kdegames/kreversi/kreversiscene.cpp 1278817 
>   trunk/KDE/kdegames/kreversi/mainwindow.h 1278817 
>   trunk/KDE/kdegames/kreversi/mainwindow.cpp 1278817 
>   trunk/KDE/kdegames/kreversi/module.dsc 1278817 
> 
> Diff: http://svn.reviewboard.kde.org/r/6897/diff/
> 
> 
> Testing
> -------
> 
> Tested playing and demo mode. No regressions found.
> 
> 
> Thanks,
> 
> Stefan Majewsky
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120212/eed50d3d/attachment.html>