[Kde-games-devel] Review Request: remove KGGZ dependency from KBattleShip (aka Naval Battle)

Stefan Majewsky majewsky at gmx.net
Fri Feb 10 17:50:32 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6895/
-----------------------------------------------------------

(Updated Feb. 10, 2012, 5:50 p.m.)


Review request for KDE Games and Paolo Capriotti.


Changes
-------

Don't remove the non-GGZ-based network code.


Description (updated)
-------

As discussed on kde-games-devel@, I'm starting to remove KGGZ from kdegames.


Diffs (updated)
-----

  trunk/KDE/kdegames/kbattleship/src/CMakeLists.txt 1278817 
  trunk/KDE/kdegames/kbattleship/src/mainwindow.h 1278817 
  trunk/KDE/kdegames/kbattleship/src/mainwindow.cpp 1278817 
  trunk/KDE/kdegames/kbattleship/src/module.dsc 1278817 
  trunk/KDE/kdegames/kbattleship/src/playfield.h 1278817 
  trunk/KDE/kdegames/kbattleship/src/playfield.cpp 1278817 
  trunk/KDE/kdegames/kbattleship/src/simplemenu.h 1278817 
  trunk/KDE/kdegames/kbattleship/src/simplemenu.cpp 1278817 

Diff: http://svn.reviewboard.kde.org/r/6895/diff/diff


Testing (updated)
-------

Played the game a few times. Both singleplayer and GGZ-less multiplayer works.


Thanks,

Stefan Majewsky

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120210/299b34e9/attachment.html>


More information about the kde-games-devel mailing list