[Kde-games-devel] Review Request: Avoid a crash when knavalbattle receives a valid (but understood) xml message

Commit Hook null at kde.org
Sun Dec 9 10:31:19 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107554/#review23188
-----------------------------------------------------------


This review has been submitted with commit e797a955b8b9d8461850c532b847ed8f838e40a2 by Jaime Torres to branch master.

- Commit Hook


On Dec. 2, 2012, 9:51 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107554/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2012, 9:51 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Avoid a crash when knavalbattle receives a valid (but understood) xml message.
> When the not understood message (for example, the one needed to enable/disable adjacent ships, for KDE SC 4.11) is received, msg is null.
> 
> 
> Diffs
> -----
> 
>   src/networkentity.cpp 3367389 
> 
> Diff: http://git.reviewboard.kde.org/r/107554/diff/
> 
> 
> Testing
> -------
> 
> Does not crash, even when does not receives a non valid xml message.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121209/d285a6c0/attachment.html>


More information about the kde-games-devel mailing list