[Kde-games-devel] Review Request: Fix for bug 272512

[Albert Astals Cid]

El Dissabte, 8 de desembre de 2012, a les 23:02:18, Nemanja Hirsl va escriure:
> It looks like change for this rewiew has been already submitted on 10/14/12
> "Apply patch by Del to solve bug #272512"
> 0622b9bf7753f9ed246a4ea6ebc42261b2fa55c5. I guess that only rewiew should
> be closed?

Ah, didn't see that. Marked as submitted.

Cheers,
  Albert

> 
> Regards,
> Nemanja
> 
> On Saturday, December 08, 2012 09:40:53 PM Albert Astals Cid wrote:
> 
> 
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106769/
> 
> 
> Review request for KDE Games and Gaël de Chalendar.
> By Del Only.
> Updated Dec. 8, 2012, 9:40 p.m.
> Changes
> Gaël?
> 
> Summary (updated)
> Fix for bug 272512
> 
> Description
> This bug has been present for years now, so I finally got around to chasing
> it down. It is always reproducible across distributions and KDE releases,
> and is rather critical for Ksirk. I posted the patch on the bug tracker,
> but I assume the mailing list is the appropriate place.
> 
> Anyway, the bug is caused by the slot SlideClose being triggered twice in
> InvasionSlilder.cpp. Hence, the number on the slider (total number of armies
> to move minus three) is moved twice. I removed the duplicate entry, and
> this seems to have fixed the bug.
> 
> Testing
> Couple of hours of playing. No trace of the bug.
> 
> Diffs
> ksirk/Dialogs/InvasionSlider.cpp (724c8d9)
> View Diff