[Kde-games-devel] Review Request: Fix for bug 272512

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106769/
-----------------------------------------------------------

(Updated Dec. 8, 2012, 9:40 p.m.)


Review request for KDE Games and Gaël de Chalendar.


Changes
-------

Gaël?


Summary (updated)
-----------------

Fix for bug 272512


Description
-------

This bug has been present for years now, so I finally got around to chasing it 
down. It is always reproducible across distributions and KDE releases, and is 
rather critical for Ksirk. I posted the patch on the bug tracker, but I assume 
the mailing list is the appropriate place.

Anyway, the bug is caused by the slot SlideClose being triggered twice in 
InvasionSlilder.cpp. Hence, the number on the slider (total number of armies 
to move minus three) is moved twice. I removed the duplicate entry, and this 
seems to have fixed the bug.


Diffs
-----

  ksirk/Dialogs/InvasionSlider.cpp 724c8d9 

Diff: http://git.reviewboard.kde.org/r/106769/diff/


Testing
-------

Couple of hours of playing. No trace of the bug.


Thanks,

Del Only

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121208/08411762/attachment.html>