[Kde-games-devel] Review Request: Fix config not saved on Quit
Parker Coates
coates at kde.org
Wed Dec 5 00:16:42 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107586/#review22999
-----------------------------------------------------------
Ship it!
Makes sense to me.
- Parker Coates
On Dec. 5, 2012, 12:03 a.m., Christoph Feck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107586/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2012, 12:03 a.m.)
>
>
> Review request for KDE Games and Stefan Majewsky.
>
>
> Description
> -------
>
> Call close() on window, instead of just deleting the app. The latter does not cause the window destructor to be called, because the window is not a child of the app.
>
>
> This addresses bug 311154.
> http://bugs.kde.org/show_bug.cgi?id=311154
>
>
> Diffs
> -----
>
> src/mainwindow.cpp ed31e87
>
> Diff: http://git.reviewboard.kde.org/r/107586/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christoph Feck
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121205/2e4ca3f8/attachment.html>
More information about the kde-games-devel
mailing list