[Kde-games-devel] Review Request: Support for QtQuick in libkdegames

[Albert Astals Cid]

> On Aug. 9, 2012, 10:23 p.m., Albert Astals Cid wrote:
> > trunk/KDE/kdegames/libkdegames/CMakeLists.txt, line 17
> > <http://svn.reviewboard.kde.org/r/7017/diff/2/?file=48263#file48263line17>
> >
> >     this is not how you do dependencies, you do a regular find + macro_log_feature
> 
> Viranch Mehta wrote:
>     Like this:
>     
>     find_package(KDeclarative)
>     macro_log_feature(KDECLARATIVE_FOUND "KDeclarative" "KDeclarative is a KDE library for KDE specific QML support." "" TRUE "" "KDeclarative library is required for QML support in KDE Games.")
>     
>     ?

Check how it is done in other places, e.g. in the same CMakeLists.txt you are editing ;-)

macro_optional_find_package(OpenAL)
macro_log_feature(OPENAL_FOUND "OpenAL" "OpenAL (Open Audio Library) is a free software cross-platform audio API." "http://connect.creativelabs.com/openal" FALSE "" "Phonon is used as a fallback, but low-latency sound output is only available with OpenAL/SndFile.")


> On Aug. 9, 2012, 10:23 p.m., Albert Astals Cid wrote:
> > trunk/KDE/kdegames/libkdegames/declarativeimports/canvasitem.h, line 4
> > <http://svn.reviewboard.kde.org/r/7017/diff/2/?file=48265#file48265line4>
> >
> >     If we are not installing this i'd call it canvasitem_p.h
> 
> Viranch Mehta wrote:
>     How does this work? I renamed the file, changed the #include in the .cpp and the compiler gives the error that canvasitem.h file cannot be found required by the canvasitem.moc
> 
> Albert Astals Cid wrote:
>     Remove your .moc includes, this is automagically handled by cmake+automoc.
>     
>     That failing have a look at how kdelibs/kdeui/notifications/knotificationmanager_p.h does it
> 
> Viranch Mehta wrote:
>     Done, does this also apply to all other headers files in the patch that we are not going to ship?

Yep, non-installed headers are usually named _p.h to signal they are private.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/7017/#review10918
-----------------------------------------------------------


On Aug. 9, 2012, 9:42 p.m., Viranch Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/7017/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2012, 9:42 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This patch contains some new stuff for libkdegames mainly to support future porting of KDE games to QtQuick/QML. Post this patch, libkdeclarative becomes a dependency for libkdegames.
> 
> There are two new things:
> 
> 1. KgDeclarativeView:
> This is a QDeclarativeView with KDE-specific import paths for QML components configured and javascript functions bindings added (like i18n() methods) using the KDeclarative library. If the view is supplied with a KGameRenderer object, it is added to the underlying declarative engine so that it can be used by QML components built for use in QML ports.
> 
> 2. CanvasItem QML component(the name of the component can be changed as per suggestions):
> This is a QML component that simply loads specified sprite pixmap from the theme provided by the KGameRenderer. The component uses the KGameRenderer instance from the engine (as set by the KgDeclarativeView) and loads the theme-specific sprite pixmap. The sprite retrieval is asynchronous and is done by using KGameRendererClient, this has potential for performance improvements.
> 
> The documentation on how to use these is inline with the code.
> 
> The kgdeclarativeview{.h,.cpp} are in libkdegames and the QML component is in declarativeimports/ directory.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/libkdegames/CMakeLists.txt 1309184 
>   trunk/KDE/kdegames/libkdegames/declarativeimports/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/declarativeimports/canvasitem.h PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/declarativeimports/canvasitem.cpp PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/declarativeimports/corebindingsplugin.h PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/declarativeimports/corebindingsplugin.cpp PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/declarativeimports/qmldir PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/includes/CMakeLists.txt 1309184 
>   trunk/KDE/kdegames/libkdegames/includes/KgDeclarativeView PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/kgdeclarativeview.h PRE-CREATION 
>   trunk/KDE/kdegames/libkdegames/kgdeclarativeview.cpp PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/7017/diff/
> 
> 
> Testing
> -------
> 
> Tested with my the ongoing port of KBreakout, works as expected.
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121201/ddf1547c/attachment.html>