[Kde-games-devel] Review Request: Fix graphical glich if 'esc' is pressed after entering shipcount.

[Michael Reeves]

> On July 31, 2012, 10:19 p.m., Albert Astals Cid wrote:
> > What are the steps to reproduce the glitch?
> 
> Michael Reeves wrote:
>     1)Click a source planet
>     2)enter a number of ships
>     3) Three hit escape.
>     
>     The ** characters will remain after the edit field is disable.
> 
> Albert Astals Cid wrote:
>     I guess you have
>     1.5) Click target planet
>     
>     When i press escape the field hides not disables, which KDE/konquest version are you using?
> 
> Michael Reeves wrote:
>     That should have read hides. I just upgraded to 2.1. I don't know what I had previously.
> 
> Michael Reeves wrote:
>     same version just kde is 4.9 now.
> 
> Albert Astals Cid wrote:
>     Not sure i understand you, are you saying the field hides for you in 4.9? If it hides there's no glitch, right?

Actually it does seem to be fixed in 4.9. The behavior before was that the edit field would go away but the characters in it weren't erased. I'm going to close this for now since it seems to be fixed.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/7014/#review10895
-----------------------------------------------------------


On July 30, 2012, 7:41 p.m., Michael Reeves wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/7014/
> -----------------------------------------------------------
> 
> (Updated July 30, 2012, 7:41 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Clear the shipcount edit field if 'esc' is pressed
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.8/kdegames/konquest/gameview.cc 1308596 
> 
> Diff: http://svn.reviewboard.kde.org/r/7014/diff/
> 
> 
> Testing
> -------
> 
> Verrified normal functionality after fix. No longer displays stray '*' characters after edit field is switched off.
> 
> 
> Thanks,
> 
> Michael Reeves
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120807/15db0de2/attachment.html>