[Kde-games-devel] Review Request: Porting KBounce to KgSound

[Ian Wadham]

> On Aug. 5, 2012, 3:16 p.m., Albert Astals Cid wrote:
> > What happened with this? Was it commited? Is there anything blocking it?

Committing this port and Roney's port of KBounce to QGraphicsView were held back initially by the 4.9 release freezes and more recently by my own inertia due to personal and health issues. I will revisit KBounce in the next few days. There is also a problem with its messages appearing in "black-on-black" in an Apple environment, which I can solve by re-coding with KGamePopupItem.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6930/#review10902
-----------------------------------------------------------


On April 27, 2012, 11:06 p.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6930/
> -----------------------------------------------------------
> 
> (Updated April 27, 2012, 11:06 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> The changed files were:
> - CMakeLists.txt
> - board.h
> - board.cpp
> - gamewidget.h
> - gamewidget.cpp
> - mainwindow.cpp
> - wall.h
> - wall.cpp
> 
> The class KBounceSound is no more necessary.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kbounce/CMakeLists.txt 1292134 
>   /trunk/KDE/kdegames/kbounce/board.h 1292134 
>   /trunk/KDE/kdegames/kbounce/board.cpp 1292134 
>   /trunk/KDE/kdegames/kbounce/gamewidget.h 1292134 
>   /trunk/KDE/kdegames/kbounce/gamewidget.cpp 1292134 
>   /trunk/KDE/kdegames/kbounce/mainwindow.cpp 1292134 
>   /trunk/KDE/kdegames/kbounce/wall.h 1292134 
>   /trunk/KDE/kdegames/kbounce/wall.cpp 1292134 
> 
> Diff: http://svn.reviewboard.kde.org/r/6930/diff/
> 
> 
> Testing
> -------
> 
> I've played the game in the following conditions:
> - sounds enabled and running
> - sounds disable and running
> - paused, sounds disabled, and then running
> - paused, sounds enabled, and then running
> 
> I could not advance to the next levels because there is a commented block of code in the file that handles the main window. Since I don't know whether there's someone working on it, thought that would be better leave it the way it is. 
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120805/02c4cd0f/attachment.html>