[Kde-games-devel] Review Request: Increase the Row Height of Kiriki

[Albert Astals Cid]

> On April 6, 2012, 1:31 p.m., Albert Astals Cid wrote:
> > /trunk/KDE/kdegames/kiriki/src/kiriki.cpp, line 329
> > <http://svn.reviewboard.kde.org/r/6931/diff/2/?file=47797#file47797line329>
> >
> >     No need to iterate over the rows, just have a redraw and then in the redraw funcion use the two parameters to specify that the whole table needs to be redrawn.
> 
> Arjun Basu wrote:
>     I saw in the Qt Documentation that if the two parameters to dataChanged() are the same then it redraws the entire table but in the redraw function when I tried emit dataChanged(mi,mi) it was not working. Is this approach correct?

Not sure where you read that, the two parameters to dataChanged are the topleft and the bottomright of the are whose data changed.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6931/#review10755
-----------------------------------------------------------


On April 6, 2012, 1:13 p.m., Arjun Basu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6931/
> -----------------------------------------------------------
> 
> (Updated April 6, 2012, 1:13 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This is in response to the feature request https://bugs.kde.org/show_bug.cgi?id=225582. Now, there is a provision of increasing the font size and as a result the row height increases too. The value of the font size in the preferences can take values from 0 to 10. O being the default font size.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kiriki/src/configPage.ui 1282954 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1282954 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.kcfg 1282954 
>   /trunk/KDE/kdegames/kiriki/src/row.h 1282954 
>   /trunk/KDE/kdegames/kiriki/src/scores.h 1282954 
>   /trunk/KDE/kdegames/kiriki/src/scores.cpp 1282954 
> 
> Diff: http://svn.reviewboard.kde.org/r/6931/diff/
> 
> 
> Testing
> -------
> 
> I have tested it and it works fine
> 
> 
> Screenshots
> -----------
> 
> The New Preferences Dialog
>   http://svn.reviewboard.kde.org/r/6931/s/629/
> The Game Canvas after increasing font size
>   http://svn.reviewboard.kde.org/r/6931/s/630/
> 
> 
> Thanks,
> 
> Arjun Basu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120406/54e0df7a/attachment.html>