[Kde-games-devel] Review Request: Increase the Row Height of Kiriki
Arjun Basu
arjunkbasu at gmail.com
Mon Apr 2 05:14:31 UTC 2012
> On April 1, 2012, 9:16 p.m., Albert Astals Cid wrote:
> > Some comments:
> > * Please make so that the font change is applied immediately not on new game start
> > * Let the user choose the font size in points not in an arbitrary 0 to 10 scale
On making the changes appear immediately , the rows take time to resize to the changed font size, which doesn't look so good visually. Should I still implement that.
I didn't understand your second point completely, regarding choosing the font size in points, are you implying that the user should get to choose the actual point size of the font?
- Arjun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6931/#review10742
-----------------------------------------------------------
On March 31, 2012, 9:30 p.m., Arjun Basu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6931/
> -----------------------------------------------------------
>
> (Updated March 31, 2012, 9:30 p.m.)
>
>
> Review request for KDE Games.
>
>
> Description
> -------
>
> This is in response to the feature request https://bugs.kde.org/show_bug.cgi?id=225582. Now, there is a provision of increasing the font size and as a result the row height increases too. The value of the font size in the preferences can take values from 0 to 10. O being the default font size.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdegames/kiriki/src/configPage.ui 1282954
> /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1282954
> /trunk/KDE/kdegames/kiriki/src/kiriki.kcfg 1282954
> /trunk/KDE/kdegames/kiriki/src/row.h 1282954
> /trunk/KDE/kdegames/kiriki/src/scores.h 1282954
> /trunk/KDE/kdegames/kiriki/src/scores.cpp 1282954
>
> Diff: http://svn.reviewboard.kde.org/r/6931/diff/
>
>
> Testing
> -------
>
> I have tested it and it works fine
>
>
> Screenshots
> -----------
>
> The New Preferences Dialog
> http://svn.reviewboard.kde.org/r/6931/s/629/
> The Game Canvas after increasing font size
> http://svn.reviewboard.kde.org/r/6931/s/630/
>
>
> Thanks,
>
> Arjun Basu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120402/fa57f455/attachment-0001.html>
More information about the kde-games-devel
mailing list