[Kde-games-devel] Review Request: Konquest: Implement standing orders

[Jeffrey Kelling]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6805/
-----------------------------------------------------------

(Updated Sept. 18, 2011, 1:22 a.m.)


Review request for KDE Games and Pierre Ducroquet.


Changes
-------

Adjust to refactoring.

When creating standing order: remove upper bound on ship count (currently available ships are not relevant to standing orders).


Summary
-------

This patch implements standing orders, i.e. orders that are repeated each turn if possible. Standing orders are issued the same way as normal order, additionally the added check box has to be checked. They are also removed the same way as normal orders (in the fleet overview). The orders are executed at the end of turn if enough ships are available, if not a message is issued. If the Planet is no longer under the players control the order is deleted. 

The number of ships that will be send due to standing order from a planet is displayed in that planets planet info (to its owner only).


This addresses bug 87882.
    https://bugs.kde.org/show_bug.cgi?id=87882


Diffs (updated)
-----

  trunk/KDE/kdegames/konquest/fleet.h 1253268 
  trunk/KDE/kdegames/konquest/fleet.cc 1253268 
  trunk/KDE/kdegames/konquest/fleetdlg.cc 1253268 
  trunk/KDE/kdegames/konquest/gamelogic.cc 1253268 
  trunk/KDE/kdegames/konquest/gameview.h 1253268 
  trunk/KDE/kdegames/konquest/gameview.cc 1253268 
  trunk/KDE/kdegames/konquest/mapitems.cc 1253268 
  trunk/KDE/kdegames/konquest/player.h 1253268 
  trunk/KDE/kdegames/konquest/player.cc 1253268 

Diff: http://svn.reviewboard.kde.org/r/6805/diff


Testing
-------

Played the game, issued standing orders, ...


Screenshots
-----------

Spawn Fleet
  http://svn.reviewboard.kde.org/r/6805/s/621/
Fleet Overview
  http://svn.reviewboard.kde.org/r/6805/s/622/
Ships needed for standing orders in planet info
  http://svn.reviewboard.kde.org/r/6805/s/623/


Thanks,

Jeffrey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20110918/1742d15f/attachment.html>