[Kde-games-devel] Review Request: make kolf compilable with microsoft visual C++

[Wolfgang Rohdewald]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6621/
-----------------------------------------------------------

Review request for kde-windows, KDE Games and Stefan Majewsky.


Summary
-------

this compiler does not know LLU for integer literals,
it expects ULL

g++ 4.4.5 also works with ULL - it treats them both
equal

it seems that ULL is more standard:
http://gcc.gnu.org/onlinedocs/gcc/Long-Long.html
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2005/n1811.pdf


Diffs
-----

  /trunk/KDE/kdegames/kolf/external/Box2D/Common/b2Math.h 1225313 

Diff: http://svn.reviewboard.kde.org/r/6621/diff


Testing
-------

with g++ 4.4.5 LLU and ULL both do the same

#include <stdio.h>
main() {
 long long unsigned int a=0x5fe6eb50c7aa19f9LLU;
 long long unsigned int b=0x5fe6eb50c7aa19f9ULL;
 printf("value a:%llx\n",a); 
 printf("value b:%llx\n",a); 
}


Thanks,

Wolfgang

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20110320/b5b5c80b/attachment.htm