[Kde-games-devel] Re: kpat solvers

[Parker Coates]

On Wed, Jan 26, 2011 at 10:24, Shlomi Fish wrote:
> On Wednesday 26 Jan 2011 10:49:49 Shlomi Fish wrote:
>> I've started working on integrating Freecell Solver into kpat and got my
>> patch in a working condition, but since then kpat was updated, and
>> furthermore, I was focusing on Freecell instead of Simple Simon.
>
> Today I did a lot of further work on the patch, and it can now also be used
> for Simple Simon. You can find it at the temporary location of:
>
> http://www.shlomifish.org/kpat-fc-solve/
>
> There are many standing issues in the patch, such as duplicate code and some
> possible memory leaks, which I am aware of, but comments are welcome. I'd like
> to clean it up and put it up for review later on.

The only person really qualified to discuss technical issues
concerning the KPat solvers (and to accept or reject your patch) is
Stephan Kulow. He isn't subscribed to this list, so I've forwarded
your patch on to him. In the future, you may want to contact him
directly.

Personally, I guess my biggest question is: Is fc-solve not released
as packageable as a standalone library that KPat could link to?
Keeping a complete copy of fc-solve in the KPat repository (that will
have to be manually updated when new versions are released) seems
pretty unattractive to me.

Parker