[Kde-games-devel] Legacy code problem in libkdegames/kgame

[Andreas Beckermann]

On Saturday 31 December 2011, Ian Wadham wrote:
> > As said the code is fine if your platform supports Qt3 support.
> > 
> >> The code in question seems to be a holdover from Qt 3 days.  See:
> >> http://doc.qt.nokia.com/3.3/qdatastream.html#QDataStream-3
> >> The constructor with plain QByteArray and a mode was allowed back then.
> > 
> > It is still allowed if you are compiling with Qt3 support and we are (in
> > the platforms that have this library).
> 
> It seems only yesterday (well maybe 4 or 5 years ago) since we KDE Games
> writers were being beaten about the ears and threatened with being drummed
> out of the regiment if we kept any vestiges of Qt 3 in our code … :-)
> 
> So why is our library still relying on Qt 3 support?  And how can that be
> justifiable?

Probably because noone uses KGamePropertyArray::sort() and therefore nobody 
noticed it.

Greetings
Andi