[Kde-games-devel] Legacy code problem in libkdegames/kgame

[Albert Astals Cid]

El Divendres, 30 de desembre de 2011, a les 18:48:46, Albert Astals Cid va 
escriure:
> El Dijous, 29 de desembre de 2011, a les 13:13:44, Ian Wadham va escriure:
> > In libkdegames/kgame there is a header file kgamepropertyarray.h which
> > contains a definition for class KGamePropertyArray.  In this class there
> > is> 
> > a method declaration and definition as follows:
> >   void sort()
> >   {
> >   
> >     QByteArray b;
> >     QDataStream s(b, QIODevice::WriteOnly);
> >     ….
> >   
> >   }
> > 
> > This compiles in most environments (apparently) but failed to compile
> > when I used Macports to port kdegames 4.7.4 to my Apple Macbook.  The
> > offending header is referenced by KFourInLine.  I am still
> > investigating the details, so I do not yet know whether KFourInline
> > actually uses
> > KGamePropertyArray::sort(), but I thought I should draw this problem to
> > the KDE Games group's attention, seeing as we are so close to a KDE SC
> > 4.8 release and (I think I read somewhere) there might be no more
> > releases on the KDE SC 4.7 branch.
> 
> Yes, 4.8.0 is close and there will be no more 4.7.x
> 
> > I also wonder how this code compiles at all in KDE Games' day-to-day
> > work
> > and in KDE SC releases?
> 
> Because it's using
> 	QDataStream ( QByteArray * array, int mode )

Err, nor it's not, please ignore the rest of my email.

Albert