[Kde-games-devel] Legacy code problem in libkdegames/kgame

Ian Wadham iandw.au at gmail.com
Fri Dec 30 07:17:05 UTC 2011


Hi Gael,

On 29/12/2011, at 9:21 PM, Kleag wrote:
> Ksirk uses kgame too. I should check if this has an impact on it but I will 
> not have time in a short future, being very occupied by my recently born baby 
> and her two older sisters.
> 
Congratulations!  And I know how it is.  Even with grandchildren of those
ages I am kept busy … and I can release them to their parents when I have
had enough … :-)

This problem is not a big one, except that we should keep our libraries clean
as much as we can.

I tried commenting out the sort() method of kgamepropertyarray.h and it had
no effect on the compilation of Ksirk and KFourInLine, so evidently that method
is not used.  Also a grep -r for 'sort *(' on all KDE Games source code revealed 
only cases where the sort() method of QStringList was used, including some in
Ksirk and KFourInLine.

So not a big worry really, I would say.

Regards, Ian W.



More information about the kde-games-devel mailing list