[Kde-games-devel] Review Request: kmahjongg: timer should stop while window is minimized

[Christian Krippendorf]

> On Dec. 13, 2011, 7:37 p.m., Frederik Schwarzer wrote:
> > So, this one pauses the game if the window is minimised? What about if another window is above the game window? I tried something like that in KShisen but didn't get it beyond half-assed or broken, so I removed it again.
> > 
> > What is it here? Do you consider this feature complete or do you think, other parts of the feature have to be left out for some reason?

This feature request only wants pause on minimize and this is what this patch does. Not more. Maybe it is not a big problem to pause if the windows gets unfocused, but this has to be done in another patch i think.

Btw. pause when another window in above this one is not that cool i think. maybe someone don't want to pause then, cause he only wants to see the right part ... maybe. Just pause on minimize if someone ask me. :)

Greez


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6838/#review10544
-----------------------------------------------------------


On Nov. 25, 2011, 7:31 p.m., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6838/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2011, 7:31 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Bug List Link: https://bugs.kde.org/show_bug.cgi?id=238903
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmahjongg/kmahjongg.h 1265765 
>   trunk/KDE/kdegames/kmahjongg/kmahjongg.cpp 1265765 
> 
> Diff: http://svn.reviewboard.kde.org/r/6838/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20111213/21423904/attachment.html>