[Kde-games-devel] Review Request: kmahjongg: select the wrong Stone if i click on the shadow of another stone

[Ian Wadham]

> On Dec. 5, 2011, 9:23 a.m., Ian Wadham wrote:
> > Ship it.
> > 
> > I have tested the patch with several KMahjongg layouts, including Hole and Crab, which have multiple tile edges showing in the hole and multiple partial overlaps. Everything works fine. Clicking on a shadow selects the tile that is in shadow, provided it is not overlapped. Clicking on a tile edge selects that tile, provided it is on top and free. And I agree with Christian, that how the patch works is how it *should* work. No special cases or "Selection Assistance", please, even if it saves a click in a few cases. Simplicity is a virtue.
> 
> Frederik Schwarzer wrote:
>     Please note the feature freeze in trunk. Or does this go through as a bugfix?

It is definitely a bug fix and luckily there are no string changes in it ... BUT I think we are in a short freeze for Beta 2 tagging until 7 Dec or whenever we hear from kde-cvs-announce at kde.org.

Christian, please leave a few days before committing. You should be automatically on that announce list by getting a KDE account. Please have a look at http://techbase.kde.org/Schedules and find out about Release Schedules and Feature Lists. Also please have a look at http://techbase.kde.org/Policies/SVN_Commit_Policy, especially the section about "Special Keywords in SVN Log Messages" re committing bug fixes.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6839/#review10519
-----------------------------------------------------------


On Dec. 3, 2011, 1:34 p.m., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6839/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2011, 1:34 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Bug List Link: https://bugs.kde.org/show_bug.cgi?id=286927
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.h 1267104 
>   trunk/KDE/kdegames/kmahjongg/boardwidget.cpp 1267104 
> 
> Diff: http://svn.reviewboard.kde.org/r/6839/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20111205/0047ef01/attachment.html>