[Kde-games-devel] Re: Review Request: Port KLines to KGameRenderer

[Lindsay Mathieson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5399/
-----------------------------------------------------------

(Updated April 8, 2011, 5:17 a.m.)


Review request for KDE Games.


Changes
-------

Updates previous patch to trunk
Replaces "" with QString()
Converts literals to QLatin1String first
renderer.cpp/.h run through astyle


Summary
-------

Updates klines to use KGameRenderer and KGameRenderedItem in place of QSvgRenderer and QGraphicsPixmapItem
Removes KPixmapCache usage


Diffs (updated)
-----

  /trunk/KDE/kdegames/klines/animator.cpp 1227353 
  /trunk/KDE/kdegames/klines/ballitem.h 1227353 
  /trunk/KDE/kdegames/klines/ballitem.cpp 1227353 
  /trunk/KDE/kdegames/klines/klines.cpp 1227353 
  /trunk/KDE/kdegames/klines/previewitem.cpp 1227353 
  /trunk/KDE/kdegames/klines/renderer.h 1227353 
  /trunk/KDE/kdegames/klines/renderer.cpp 1177731 
  /trunk/KDE/kdegames/klines/scene.cpp 1227353 

Diff: http://svn.reviewboard.kde.org/r/5399/diff


Testing
-------

Playing game
Changing themes
Resizing game
Comparison with original


Thanks,

Lindsay

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20110408/80ebf11f/attachment.htm