[Kde-games-devel] Review Request: Hint in Kiriki

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/3793/#review7620
-----------------------------------------------------------


I don't have time to test it right now, but I do have a few more comments. I'd say we're almost there. :)


/trunk/KDE/kdegames/kiriki/src/diceswidget.cpp
<http://svn.reviewboard.kde.org/r/3793/#comment7767>

    There's not real need for the this pointer here. Just call style().



/trunk/KDE/kdegames/kiriki/src/kiriki.cpp
<http://svn.reviewboard.kde.org/r/3793/#comment7768>

    I turns out that there's no need to keep a "normal" delegate instance around.
    
    You can just replace "m_scoresWidget -> setItemDelegateForRow(m_highlightedRowIndex,
    m_delegateNormal);" with "m_scoresWidget -> setItemDelegateForRow(m_highlightedRowIndex, 0);" as passing a null QItemDelegate pointer causes it to revert to the default.



/trunk/KDE/kdegames/kiriki/src/kiriki.cpp
<http://svn.reviewboard.kde.org/r/3793/#comment7769>

    This needs some i18n.



/trunk/KDE/kdegames/kiriki/src/kiriki.cpp
<http://svn.reviewboard.kde.org/r/3793/#comment7770>

    Missing a space after the second ->.


- Parker


On 2010-09-14 14:34:57, Luiz Romário Santana Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/3793/
> -----------------------------------------------------------
> 
> (Updated 2010-09-14 14:34:57)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> This patch implements hint in Kiriki, using the computer itself to give it. Either some dice or a row are highlighted to give the hint.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kiriki/src/diceswidget.h 1119312 
>   /trunk/KDE/kdegames/kiriki/src/diceswidget.cpp 1119312 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.h 1119312 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1119312 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.h 1119312 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.cpp 1119312 
> 
> Diff: http://svn.reviewboard.kde.org/r/3793/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luiz Romário
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100915/b8dbf611/attachment-0001.htm