[Kde-games-devel] Review Request: Bug 251165 fix

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5337/#review7619
-----------------------------------------------------------


Looks good, but...


/trunk/KDE/kdegames/kiriki/src/lateralwidget.cpp
<http://svn.reviewboard.kde.org/r/5337/#comment7765>

    This slot is no longer used, so it should probably be removed.



/trunk/KDE/kdegames/kiriki/src/lateralwidget.cpp
<http://svn.reviewboard.kde.org/r/5337/#comment7766>

    It probably makes sense to call disableDemoMode() here to avoid repeating the same code.


- Parker


On 2010-09-14 18:34:39, Luiz Romário Santana Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5337/
> -----------------------------------------------------------
> 
> (Updated 2010-09-14 18:34:39)
> 
> 
> Review request for KDE Games and Parker Coates.
> 
> 
> Summary
> -------
> 
> Relative to bug #251165.
> 
> 
> This addresses bug 251165.
>     https://bugs.kde.org/show_bug.cgi?id=251165
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1175062 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.h 1175062 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.cpp 1175062 
> 
> Diff: http://svn.reviewboard.kde.org/r/5337/diff
> 
> 
> Testing
> -------
> 
> It seems to work fine.
> 
> 
> Thanks,
> 
> Luiz Romário
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100915/50e10d63/attachment.htm