[Kde-games-devel] Review Request: Hint in Kiriki

[Luiz Romário Santana Rios]

> On 2010-09-14 02:58:39, Parker Coates wrote:
> > /trunk/KDE/kdegames/kiriki/src/kiriki.cpp, line 214
> > <http://svn.reviewboard.kde.org/r/3793/diff/6/?file=31271#file31271line214>
> >
> >     Did you consider adding a "Do not ask again" checkbox to the dialog? It's generally a good idea for "nagging" dialogs like this one.

I don't think this is a good idea. This dialog will already only appear once per game if the user wants the hint. Why would I want it not to appear in future games? What if another user wants to make it into high scores and they does not know that taking a hint will disqualify him?


- Luiz Romário


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/3793/#review7586
-----------------------------------------------------------


On 2010-09-14 14:34:57, Luiz Romário Santana Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/3793/
> -----------------------------------------------------------
> 
> (Updated 2010-09-14 14:34:57)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> This patch implements hint in Kiriki, using the computer itself to give it. Either some dice or a row are highlighted to give the hint.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kiriki/src/diceswidget.h 1119312 
>   /trunk/KDE/kdegames/kiriki/src/diceswidget.cpp 1119312 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.h 1119312 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1119312 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.h 1119312 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.cpp 1119312 
> 
> Diff: http://svn.reviewboard.kde.org/r/3793/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luiz Romário
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100914/f9e2b871/attachment.htm