[Kde-games-devel] Review Request: Hint in Kiriki

Pino Toscano pino at kde.org
Tue Sep 14 16:23:03 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/3793/#review7602
-----------------------------------------------------------



/trunk/KDE/kdegames/kiriki/src/diceswidget.cpp
<http://svn.reviewboard.kde.org/r/3793/#comment7760>

    use the style() of the widget itself, not the application's one



/trunk/KDE/kdegames/kiriki/src/kiriki.cpp
<http://svn.reviewboard.kde.org/r/3793/#comment7761>

    use && instead of 'and', as the latter creates issues on some compilers



/trunk/KDE/kdegames/kiriki/src/kiriki.cpp
<http://svn.reviewboard.kde.org/r/3793/#comment7759>

    make it static and const


- Pino


On 2010-09-14 14:12:12, Luiz Romário Santana Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/3793/
> -----------------------------------------------------------
> 
> (Updated 2010-09-14 14:12:12)
> 
> 
> Review request for KDE Games.
> 
> 
> Summary
> -------
> 
> This patch implements hint in Kiriki, using the computer itself to give it. Either some dice or a row are highlighted to give the hint.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kiriki/src/diceswidget.h 1119312 
>   /trunk/KDE/kdegames/kiriki/src/diceswidget.cpp 1119312 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.h 1119312 
>   /trunk/KDE/kdegames/kiriki/src/kiriki.cpp 1119312 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.h 1119312 
>   /trunk/KDE/kdegames/kiriki/src/lateralwidget.cpp 1119312 
> 
> Diff: http://svn.reviewboard.kde.org/r/3793/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luiz Romário
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100914/b6036b56/attachment.htm 


More information about the kde-games-devel mailing list