[Kde-games-devel] Review Request: Do not use setCornerWidget() when menubar is native

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5334/#review7592
-----------------------------------------------------------

Ship it!


I cannot test the isNativeMenuBar() == true case, but I trust that you did test it carefully.

- Stefan


On 2010-09-13 16:49:16, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5334/
> -----------------------------------------------------------
> 
> (Updated 2010-09-13 16:49:16)
> 
> 
> Review request for KDE Games and Stefan Majewsky.
> 
> 
> Summary
> -------
> 
> Upcoming Kubuntu features a Qt patch and Plasma widget which makes it possible to show application menubars in a Plasma panel. You can learn more about it there: https://wiki.ubuntu.com/DesktopExperienceTeam/ApplicationMenu . This feature does not work with Palapeli right now because it moves its menubar in the corner of the tab widget.
> 
> This review requests does not move the menubar if it is native. This ensures it is properly exported and displayed in the panel menubar. It should also be useful on Mac OS X but I haven't tested.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/palapeli/src/window/mainwindow.cpp 1161399 
> 
> Diff: http://svn.reviewboard.kde.org/r/5334/diff
> 
> 
> Testing
> -------
> 
> Tested with and without the panel menubar.
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100914/0062cf19/attachment.htm