[Kde-games-devel] Review Request: Port KMines to KGameRenderer

[Brian Croom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5192/
-----------------------------------------------------------

(Updated 2010-09-02 20:16:48.819760)


Review request for KDE Games, Stefan Majewsky and Dmitry Suzdalev.


Summary
-------

This patch ports KMines to use KGameRenderer.

The only complication for this one was the layered pixmaps used when displaying cells. As for KReversi, I added KGameRenderedItem instances as children of the cell item, which seems to work well. Let me know what you think of the implementation in this case.


Diffs (updated)
-----

  /trunk/KDE/kdegames/kmines/CMakeLists.txt 1168585 
  /trunk/KDE/kdegames/kmines/borderitem.h 1168585 
  /trunk/KDE/kdegames/kmines/borderitem.cpp 1168585 
  /trunk/KDE/kdegames/kmines/cellitem.h 1168585 
  /trunk/KDE/kdegames/kmines/cellitem.cpp 1168585 
  /trunk/KDE/kdegames/kmines/main.cpp 1168585 
  /trunk/KDE/kdegames/kmines/mainwindow.cpp 1168585 
  /trunk/KDE/kdegames/kmines/minefielditem.h 1168585 
  /trunk/KDE/kdegames/kmines/minefielditem.cpp 1168585 
  /trunk/KDE/kdegames/kmines/renderer.h 1168585 
  /trunk/KDE/kdegames/kmines/renderer.cpp 1168585 
  /trunk/KDE/kdegames/kmines/scene.h 1168585 
  /trunk/KDE/kdegames/kmines/scene.cpp 1168585 

Diff: http://svn.reviewboard.kde.org/r/5192/diff


Testing
-------

Brief testing has revealed no regressions. Resizing and theme changes work properly.


Thanks,

Brian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-games-devel/attachments/20100902/3d95d2ec/attachment.htm